Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roswtf: do not try to run online checks if there are no roslaunch uris #1848

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

flixr
Copy link
Contributor

@flixr flixr commented Dec 6, 2019

If there are no roslaunch uris, roswtf aborts checks with a traceback:

Traceback (most recent call last):
  File "/opt/ros/melodic/lib/python2.7/dist-packages/roswtf/__init__.py", line 220, in _roswtf_main
    roswtf.roslaunchwtf.wtf_check_online(ctx)
  File "/opt/ros/melodic/lib/python2.7/dist-packages/roswtf/roslaunchwtf.py", line 297, in wtf_check_online
    warning_rule(r, r[0](ctx), ctx)
  File "/opt/ros/melodic/lib/python2.7/dist-packages/roswtf/roslaunchwtf.py", line 202, in roslaunch_respawn_check
    for uri in ctx.roslaunch_uris:
TypeError: 'NoneType' object is not iterable
'NoneType' object is not iterable

So do not try to run online checks if there are no roslaunch_uris to fix this.

@flixr flixr changed the title do not try to run online checks if there are no roslaunch uris roswtf: do not try to run online checks if there are no roslaunch uris Dec 6, 2019
@flixr
Copy link
Contributor Author

flixr commented Jan 7, 2020

The failed one looks like a flaky test.
I see basically zero risk in this...
Can we please get this merged?

@mikepurvis
Copy link
Member

Yup, thanks for the ping— this looks reasonable, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants