Fix (#1516), prevent indefinitely trapping in unknown error state #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall we merge this PR? @mikepurvis @dirk-thomas |
|
@dirk-thomas reviewed the previous patch that this builds on, so I'd prefer he look here as well. |
|
@mikepurvis, you're right. By the way, failed checks seem to be irrelevant. |
|
The Noetic checks are expected to fail (for now) since none of Noetic has been bloomed other than If the Melodic checks pass, it's fine. |
flixr
approved these changes
Jan 12, 2020
|
Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with #1517 we still observe unknown network error time out, but this time, indefinitely (#1516 (comment)). Adding false return on
ValueErrorseems to be the only fix for now.