Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTP/1.1 in XMLRPC Server #1287

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Conversation

mgrrx
Copy link
Contributor

@mgrrx mgrrx commented Dec 31, 2017

This PR activates HTTP/1.1 in the XMLRPC Server and fixes the CTRL-C issues that were reported in #371

Setting daemon_threads to True allows the program to terminate.

@dirk-thomas
Copy link
Member

Thank you for the patch. This looks really promising! It works for me in the case described in the referenced earlier PR.

@mikepurvis Could you give this patch a try by using it in your deployment for some days?

@mikepurvis
Copy link
Member

Looks great, thanks!

@mikepurvis mikepurvis merged commit 5e2b38e into ros:lunar-devel Apr 23, 2018
@mikepurvis
Copy link
Member

mikepurvis commented Apr 23, 2018

Oh shoot, wrong target branch.

mikepurvis added a commit that referenced this pull request Apr 23, 2018
This reverts commit 5e2b38e.

This change may be considered for backporting to Lunar at a later time.
mikepurvis pushed a commit that referenced this pull request Apr 23, 2018
@mikepurvis
Copy link
Member

Reverted from Lunar, cherry-picked to Melodic as per the linked commits above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants