changes between 1.12.13 and 1.13.7 for backporting #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to use the operator<< also with const references to XmlRpcValue objects, not only non-const ones.
* Skip empty lines * Only check 'Header ' is at the beginning This allows to support sensor_msgs/Image, which has a comment after. Also note we only need to check for the type, not the name of the field. * Break while loop after first field.
* Add substitution when loading yaml files like in #1051 * Add tests
* Template std::max instead of casting explicitly.
* Make a copy of the topic list get_topics() returns a set, which is iterated by the Log constructor. Make a copy of the set (atomic in cpython!) so nobody adds or removes something while the Log constructor iterates over it * Revert "Make a copy of the topic list", Fix This reverts commit 0e019e0. Move the fix to the _TopicManager so anybody else calling get_topics doesn't get burned by the same issue as _rosout
…1450) * Rename getLastestTime to getLatestTime Per directions [here](#1449 (comment)). * Test getLatestTime instead of getLastestTime per #1449 (comment)
|
@ros-pull-request-builder retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following list of changes has been integrated into
ros_comm1.13.7 (Lunar) since the last Kinetic release (1.12.13).Commits already in
kinetic-devel:Backported: (these changes are part of this PR)
Take XmlRpcValue by const ref. in operator<< (Take XmlRpcValue by *const* ref. in operator<< #1350)
Fix check for header first in rosbag play for rate control topic (Fix check for header first in rosbag play for rate control topic #1352)
Add substitution when loading yaml files (Add substitution when loading yaml files #1354)
rosbag record: Add TransportHint options --tcpnodelay and --udp (rosbag record: Add TransportHint options --tcpnodelay and --udp #1295)
topic_tools: Check that output topic is valid in demux (topic_tools: Check that output topic is valid in demux. Fixes #1366 #1367)
Replaced Double-Checked Locking pattern with static variable (Replaced Double-Checked Locking pattern with static variable. Fixes #1364 #1365)
Fix "pass_all_args" for roslaunch-check, add nosetest (fix "pass_all_args" for roslaunch-check #1368)
Convert the period standard deviation in StatisticsLogger to Duration at the end. (Rework the period standard deviation calculation in Sta… #1361)
Fix integer overflow for oneshot timers. (Fix integer overflow for oneshot timers. #1382)
Change to force a rebuild of the pollset on flag changes (Change to force a rebuild of the pollset on flag changes #1393)
Fix Issue 1346 - Make a copy of the topic list (Fix Issue 1346 - Make a copy of the topic list #1416)
Rename python message_filters.Cache.getLastestTime to getLatestTime (Rename python message_filters.Cache.getLastestTime to getLatestTime #1450)
Add hasStarted()const to Timer API (Add hasStarted() const to Timer API #1464)
Not backported: (present on the
lunar-develbranch and/or part of the backport to Lunar #1477)fix various compiler warnings on bionic (fix various compiler warnings on bionic #1325)
Add rosconsole echo (Add rosconsole echo #1324)
Created public get_topic_list() function for use in other scripts (Created public get_topic_list() function for use in other scripts. #1154)
Use HTTP/1.1 in XMLRPC Server (Use HTTP/1.1 in XMLRPC Server #1287)
XmlRpcpp fixes for OSX (XmlRpcpp fixes for OSX #1402)
Fix the count of subscribers. (Fix the count of subscribers. #1407)
Fix some errors in some probably not frequented code paths (Fix some errors in some probably not frequented code paths melodic #1415)
@ros/ros_team @ros/ros_comm-maintainers RFC.