roslaunch-check: Search dir recursively

[mortenfyhn]

Hi! What do yall think about something like this?

This will simply check all .launch files in the directory you pass, including
subdirectories. I recently set up roslaunch-check on a CI server, and
missed having a feature like this.

However, the directory you pass must still be a ROS package
or a subdirectory of a ROS package. If you have, say, a dir
containing many packages, and you want to check every launch
file in every package in that dir, then you'll need to invoke
roslaunch-check once for each package.

[Rayman]

This already works like this? Try to give a directory as argument:

rosrun roslaunch roslaunch-check launch/
checking *.launch in directory launch/
...

Edit: You are right, it's normally does not recurse into subdirectories

[mortenfyhn]

Either I'm very confused, or something caused it to not work that way on my machine. Hang on, I'll double check.

[mortenfyhn]

(I'm running Melodic.)

It seems that if I have a package that for instance looks like this

my_package
├── CMakeLists.txt
├── launch
│   ├── foo.launch
│   ├── bar.launch
│   └── baz
│       └── foobar.launch
└── package.xml

then

rosrun roslaunch roslaunch-check my_package/launch

will check foo.launch and bar.launch, but not foobar.launch, presumably because it's in a subdirectory.

[dirk-thomas]

Please target the default branch (which is noetic-devel).

[mortenfyhn]

Done!

[mortenfyhn]

I'm also very interested in what you think about a further change to allow passing a non-ROS-package dir (to check all launch files in an entire workspace, for instance).

[dirk-thomas]

@ros-pull-request-builder retest this please

[dirk-thomas]

Thanks for the patch.

[mortenfyhn]

Thanks for merging!