XmlRpcValue::_doubleFormat should be used during write.

[fujitatomoya]

fix #1958

Signed-off-by: Tomoya.Fujita Tomoya.Fujita@sony.com

[peci1]

This PR should contain a test that would verify the behavior.

[fujitatomoya]

@dirk-thomas @peci1

could you take a look at it when you got time?

i confirmed catkin_make run_tests_xmlrpcpp_gtest_TestValues XmlRpc.testDouble got green light.

[dirk-thomas]

Beside the inline comment it seems that some unit tests are failing now in the PR builds.

[fujitatomoya]

Beside the inline comment it seems that some unit tests are failing now in the PR builds.

I will check on those,

[peci1]

As the double format is static, it is shared by all code. After your test finishes, you should set doubleformat back to the default "%.16g". This should get the other tests green.

[fujitatomoya]

@peci1

nice catch!!! thanks for the information, that helps 😄 (actually i did not have time to look into...)

[fujitatomoya]

local test shows green light,

# catkin_make run_tests_xmlrpcpp_gtest_TestValues
Base path: /root/catkin_ws
Source space: /root/catkin_ws/src
Build space: /root/catkin_ws/build
Devel space: /root/catkin_ws/devel
Install space: /root/catkin_ws/install
####
#### Running command: "make cmake_check_build_system" in "/root/catkin_ws/build"
####
####
#### Running command: "make run_tests_xmlrpcpp_gtest_TestValues -j24 -l24" in "/root/catkin_ws/build"
####
[ 50%] Built target gtest
[100%] Built target xmlrpcpp
[100%] Built target TestValues
-- run_tests.py: execute commands
  /root/catkin_ws/devel/lib/xmlrpcpp/TestValues --gtest_output=xml:/root/catkin_ws/build/test_results/xmlrpcpp/gtest-TestValues.xml
[==========] Running 12 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 11 tests from XmlRpc
[ RUN      ] XmlRpc.Bool
[       OK ] XmlRpc.Bool (0 ms)
[ RUN      ] XmlRpc.testBoolean
[       OK ] XmlRpc.testBoolean (0 ms)
[ RUN      ] XmlRpc.testInt
[       OK ] XmlRpc.testInt (0 ms)
[ RUN      ] XmlRpc.testDouble
[       OK ] XmlRpc.testDouble (0 ms)
[ RUN      ] XmlRpc.testString
[       OK ] XmlRpc.testString (0 ms)
[ RUN      ] XmlRpc.testDateTime
[       OK ] XmlRpc.testDateTime (0 ms)
[ RUN      ] XmlRpc.testArray
[       OK ] XmlRpc.testArray (1 ms)
[ RUN      ] XmlRpc.testStruct
[       OK ] XmlRpc.testStruct (5 ms)
[ RUN      ] XmlRpc.base64
[       OK ] XmlRpc.base64 (0 ms)
[ RUN      ] XmlRpc.int_errors
[       OK ] XmlRpc.int_errors (0 ms)
[ RUN      ] XmlRpc.array_errors
[       OK ] XmlRpc.array_errors (0 ms)
[----------] 11 tests from XmlRpc (6 ms total)

[----------] 1 test from XmpRpc
[ RUN      ] XmpRpc.errors
[       OK ] XmpRpc.errors (0 ms)
[----------] 1 test from XmpRpc (0 ms total)

[----------] Global test environment tear-down
[==========] 12 tests from 2 test suites ran. (6 ms total)
[  PASSED  ] 12 tests.
-- run_tests.py: verify result "/root/catkin_ws/build/test_results/xmlrpcpp/gtest-TestValues.xml"
[100%] Built target run_tests_xmlrpcpp_gtest_TestValues

[fujitatomoya]

@dirk-thomas

thanks for checking on this. we got all green, we have a go?

and would you want me to work on backport for melodic?
I am willing to do that, just let me know which version you want this to be put back.

[dirk-thomas]

and would you want me to work on backport for melodic?

Not need to. Any backport will happen in a combined PR as described in #1496.

[fujitatomoya]

@dirk-thomas

could you take a look when you got time?

[fujitatomoya]

@dirk-thomas

could you check when you got time? thanks!

[fujitatomoya]

@dirk-thomas

ping friendly,

[fujitatomoya]

@dirk-thomas

i think this one was missed under your radar, ping friendly 😄

[fujitatomoya]

@dirk-thomas

I've addressed your comments, could you take a look?

[dirk-thomas]

Thanks for the patch.