Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support large bagfiles (>2GB) on 32-bit systems in rosbag_storage #554

Merged

Conversation

mjschuster
Copy link
Contributor

The "-D_FILE_OFFSET_BITS=64" is set for rosbag, but is missing for rosbag_storage (which was factored out after fuerte).
This should fix issue #464.

@ros-pull-request-builder
Copy link
Member

Can one of the admins verify this patch?

@dirk-thomas
Copy link
Member

@ros-pull-request-builder
Copy link
Member

Test passed.
Refer to this link for build results: http://jenkins.ros.org/job/_pull_request-indigo-ros_comm/155/

@dirk-thomas
Copy link
Member

Thank you for the patch.

dirk-thomas added a commit that referenced this pull request Jan 26, 2015
support large bagfiles (>2GB) on 32-bit systems in rosbag_storage
@dirk-thomas dirk-thomas merged commit 35e5964 into ros:indigo-devel Jan 26, 2015
@flixr
Copy link
Contributor

flixr commented Jan 28, 2015

Would probably also make sense to backport it to hydro...

@gavanderhoorn
Copy link
Contributor

Looking at the commit history of hydro-devel, it doesn't look like this hasn't been backported to Hydro, has it?

I only ask because of Error playing bagfile ~4GB on 32bit system (although I'm not sure whether this is really the cause of the problem the asker has).

@dirk-thomas
Copy link
Member

Yes, the commit has yes not been cherry-picked to the hydro-devel branch. Usually I do this shortly before a new patch release and there has been no Hydro release of ros_comm since this bug has been fixed.

rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this pull request Jun 19, 2017
…pport

support large bagfiles (>2GB) on 32-bit systems in rosbag_storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants