Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rosdep] add ubuntu-sounds entry #36857

Closed
wants to merge 3 commits into from

Conversation

sktometometo
Copy link
Contributor

@sktometometo sktometometo commented Apr 14, 2023

Package name:

ubuntu-sounds package (Ubuntu's GNOME audio theme)

Package Upstream Source:

Source package is https://packages.ubuntu.com/source/focal/ubuntu-sounds. I don't where is the original project.

Purpose of using this:

Our lab have developed some package using the sound file in this package. (e.g. /usr/share/sounds/ubuntu/stereo/bell.ogg)
And it will be helpful to add the package to rosdep for our package users.

Distro packaging links:

Links to Distribution Packages

Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this as what appears to be a previously undeclared dependency for an existing ROS package, but I would say it's very suboptimal to depend on a package that is so specific to just one of the platforms that ROS is available for as it prevents this package from being released on Debian as well as Ubuntu.

If there is another more cross-platform sound library to use, that would be worth considering, or bundling the sounds you need directly in your application if they are appropriately licensed.

@sktometometo
Copy link
Contributor Author

@nuclearsandwich
Thank you for approving and advise. sound-theme-freedesktop package will be more suitable since it is distributed on multiple distribution (ubuntu, debian and already added to rosdep/base.yaml.

@tfoote
Copy link
Member

tfoote commented Apr 18, 2023

Yes that package would be much better to use. If you can use that it would be good to choose this one so that others don't end up going down the same limited path.

@audrow
Copy link
Contributor

audrow commented May 11, 2023

I'm going to close this since it seems sound-theme-freedesktop is a good solution. Feel free to reopen if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants