Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_parameter_library: remove example packages #39536

Merged
merged 3 commits into from
Jan 13, 2024

Conversation

tylerjw
Copy link
Contributor

@tylerjw tylerjw commented Jan 12, 2024

Dropping example packages from the distribution. There was no good reason for these to be packaged. I tried putting ignored files in the release repo and running a release but that didn't seem to work as I expected.

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Jan 12, 2024
@tylerjw
Copy link
Contributor Author

tylerjw commented Jan 12, 2024

So, this didn't work as I hoped. I want to remove the example packages from the distributions. There is no reason to package them. I tried pushing ignored files to the release repo and then re-running bloom: https://github.com/ros2-gbp/generate_parameter_library-release/blob/main/rolling.ignored

That did not seem to work, as is evident by the content of this PR. Is there another step I should take?

@github-actions github-actions bot added humble Issue/PR is for the ROS 2 Humble distribution iron Issue/PR is for the ROS 2 Iron distribution labels Jan 12, 2024
@tylerjw tylerjw changed the title generate_parameter_library: 0.3.7-2 in 'rolling/distribution.yaml' [bloom] generate_parameter_library: remove example packages Jan 12, 2024
@tfoote
Copy link
Member

tfoote commented Jan 13, 2024

I think that you're running into an assumption in bloom that the default branch is 'master' versus the more modern policy of 'main'

I found https://robotics.stackexchange.com/q/97981/161 and from there

https://github.com/ros-infrastructure/bloom/blob/d3d21ae9e816500154798d254422ac30e6bbee0f/bloom/config.py#L62

Where I think that bloom isn't detecting the default branch and is simply checking for a branch named master so it works for all the older repositories where master is the default, but won't work for newer ones where main is the default.

Just removing the entries here will do what you want to remove it from the buildfarm.

I made a new issue here: ros-infrastructure/bloom#721

@tfoote tfoote merged commit 2308d69 into ros:master Jan 13, 2024
4 checks passed
@tylerjw
Copy link
Contributor Author

tylerjw commented Jan 13, 2024

That makes a ton of sense. Thank you for explaining that. I had just found old examples and copied them without noticing the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution iron Issue/PR is for the ROS 2 Iron distribution rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants