Make sure to add the version when creating a new URDF. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that when I added the version stuff, I completely forgot about creating a new URDF. This PR fixes it so that we can successfully round-trip through the URDF parser, and adds tests to ensure the same. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
FabioBergonti
approved these changes
Jul 6, 2020
|
@sloretz Friendly ping on this one; mind reviewing? |
sloretz
approved these changes
Jul 10, 2020
|
Thanks, appreciate the review. Merging. |
Hi @clalancette, let us know if there is anything we can do to help to get the fix shipped also to the |
clalancette
added a commit
that referenced
this pull request
Nov 5, 2020
It turns out that when I added the version stuff, I completely forgot about creating a new URDF. This PR fixes it so that we can successfully round-trip through the URDF parser, and adds tests to ensure the same. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
It totally fell off of my radar, thanks for the ping. See #66 for the ROS 1 fix. |
clalancette
added a commit
that referenced
this pull request
Dec 4, 2020
It turns out that when I added the version stuff, I completely forgot about creating a new URDF. This PR fixes it so that we can successfully round-trip through the URDF parser, and adds tests to ensure the same. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that when I added the version stuff, I completely
forgot about creating a new URDF. This PR fixes it so that
we can successfully round-trip through the URDF parser, and
adds tests to ensure the same.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Note that once this is reviewed, approved, and merged, I'll do a similar fix for the ROS 1 code. This should fix #59