Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using wrong headers #147

Closed
audrow opened this issue Oct 27, 2020 · 2 comments
Closed

Using wrong headers #147

audrow opened this issue Oct 27, 2020 · 2 comments

Comments

@audrow
Copy link
Contributor

audrow commented Oct 27, 2020

This issue is a continuation of the issue described in ros2#23. Here is its main description:

When enabling warnings in #22, it seems enabling -Wpedantic enabled -Wgnu-zero-variadic-macro-arguments in Clang which raised the following warning (as noted here, ros2#22 (comment)):

[  3%] Building CXX object urdf_parser/CMakeFiles/urdfdom_model.dir/src/pose.cpp.o
In file included from /Users/osrf/jenkins-agent/workspace/ci_osx/ws/src/ros2/urdfdom/urdf_parser/src/pose.cpp:42:
/usr/local/include/console_bridge/console.h:67:88: warning: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Wgnu-zero-variadic-macro-arguments]
  console_bridge::log(__FILE__, __LINE__, console_bridge::CONSOLE_BRIDGE_LOG_ERROR, fmt, ##__VA_ARGS__)

Two things from this warning:

  • the console bridge is being included from usr/local, and
  • it is an older version of console_bridge (not 1.0.1), because the PR fix clang warnings console_bridge#64 hasn't been applied yet.
@sloretz
Copy link
Contributor

sloretz commented Dec 29, 2020

@audrow did #148 fix this?

@audrow
Copy link
Contributor Author

audrow commented Dec 29, 2020

@sloretz, Yes! Good catch.

@audrow audrow closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants