add dependency on ros-melodic-tf #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow bridging tf/tfMessage out of the box
|
The right approach for this is to add |
|
Edit: the package.xml is used to specify ROS2 dependencies. In this case we are missing some ROS1 package to be installed to generate mappings, so it has to be done in the control file instead of the package.xml |
|
@mjcarroll for a Dashing backport. |
|
@mjcarroll @nuclearsandwich friendly 🛎️ any chance of getting this in an upcoming release ? |
|
@jacobperron this may also be of interest for foxy |
mjcarroll
approved these changes
Jun 1, 2020
mjcarroll
pushed a commit
that referenced
this pull request
Jun 1, 2020
To allow bridging tf/tfMessage out of the box
mjcarroll
pushed a commit
that referenced
this pull request
Jun 1, 2020
To allow bridging tf/tfMessage out of the box
jacobperron
pushed a commit
that referenced
this pull request
Jun 1, 2020
jacobperron
pushed a commit
that referenced
this pull request
Jun 1, 2020
nuclearsandwich
pushed a commit
that referenced
this pull request
Jun 16, 2020
jacobperron
pushed a commit
that referenced
this pull request
Jul 8, 2020
jacobperron
pushed a commit
that referenced
this pull request
Jul 8, 2020
jacobperron
pushed a commit
that referenced
this pull request
Sep 8, 2020
jacobperron
pushed a commit
that referenced
this pull request
Sep 8, 2020
jacobperron
pushed a commit
that referenced
this pull request
Sep 8, 2020
jacobperron
pushed a commit
that referenced
this pull request
Sep 8, 2020
jacobperron
pushed a commit
that referenced
this pull request
Sep 8, 2020
jacobperron
pushed a commit
that referenced
this pull request
Sep 8, 2020
jacobperron
pushed a commit
that referenced
this pull request
Sep 9, 2020
jacobperron
pushed a commit
that referenced
this pull request
Sep 9, 2020
dirk-thomas
pushed a commit
that referenced
this pull request
Sep 10, 2020
jacobperron
pushed a commit
that referenced
this pull request
Sep 10, 2020
jacobperron
pushed a commit
that referenced
this pull request
Sep 21, 2020
jacobperron
pushed a commit
that referenced
this pull request
Sep 21, 2020
jacobperron
pushed a commit
that referenced
this pull request
Sep 21, 2020
To allow bridging tf/tfMessage out of the box
jacobperron
pushed a commit
that referenced
this pull request
Sep 21, 2020
To allow bridging tf/tfMessage out of the box
jacobperron
pushed a commit
that referenced
this pull request
Dec 8, 2020
hidmic
pushed a commit
that referenced
this pull request
Dec 9, 2020
To allow bridging tf/tfMessage out of the box
wjwwood
pushed a commit
that referenced
this pull request
Dec 9, 2020
wjwwood
pushed a commit
that referenced
this pull request
Dec 9, 2020
clalancette
pushed a commit
that referenced
this pull request
Jan 25, 2021
cottsay
pushed a commit
that referenced
this pull request
Apr 20, 2021
clalancette
pushed a commit
that referenced
this pull request
Nov 5, 2021
quarkytale
pushed a commit
that referenced
this pull request
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow bridging
tf/tfMessageout of the box.The ROS 2 version of the package has the corresponding bridging rules https://github.com/ros2/geometry2/blob/6233bc6592ee34ce2c08760d0151a03471a44097/tf2_msgs/tfmessage_bridge_mapping_rule.yaml but the factories are not generated because the ROS1 package is not installed
(would benefit from a Dashing backport too)
Edit: would address issues like https://answers.ros.org/question/349088/ros1-tf-incompatible-with-ros2-through-ros1-bridge/ when installing from debs