Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add perception open3d #57

Closed
wants to merge 1 commit into from
Closed

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented May 22, 2022

I would like to release perception_open3d packages.
https://github.com/ros-perception/perception_open3d
@SteveMacenski @jacobperron Is it possible for me to join perception.tf?

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>
@SteveMacenski
Copy link
Member

SteveMacenski commented May 23, 2022

That does not relate to this repository, the release repository for perception open3D is https://github.com/ros-gbp/perception_open3d-release

You are not a maintainer on perception_open3d so it would not be appropriate to give you permission to release on it, but you can request one in the issue tracker

@jacobperron
Copy link

jacobperron commented May 23, 2022

TBH, I'm not familiar with the process related to adding repos / maintainers to these terraform configurations. I think what Steve suggests sounds more appropriate: if you'd like a new release and/or maintainer status, opening a issue upstream makes sense to me.

@wep21
Copy link
Contributor Author

wep21 commented May 24, 2022

That does not relate to this repository, the release repository for perception open3D is https://github.com/ros-gbp/perception_open3d-release

I guess it is recommended to use ros2-gbp to release ros2 packages.

You are not a maintainer on perception_open3d so it would not be appropriate to give you permission to release on it, but you can request one in the issue tracker

I think what Steve suggests sounds more appropriate: if you'd like a new release and/or maintainer status, opening a issue upstream makes sense to me.

I created a issue in the upstream repositroy. Thanks.

@nuclearsandwich
Copy link
Collaborator

nuclearsandwich commented May 25, 2022

if you'd like a new release and/or maintainer status, opening a issue upstream makes sense to me.

As a point of procedure, I'll second / third this suggestion. It's much easier for me / the ROS infrastructure team to keep on top of requests here if they come directly from existing package maintainers or represent the outcomes of settled discussions elsewhere. I think that an excellent workflow for similar future scenarios is to open an issue upstream either requesting a release or volunteering to help with maintenance workload of making one yourself and once the conversation there settles on an outcome, linking to it in an issue or PR on this repository implementing the desired state.

@wep21 is it alright to close this PR for now? It can be re-opened if needed once ros-perception/perception_open3d#24 is settled.

the release repository for perception open3D is https://github.com/ros-gbp/perception_open3d-release

I guess it is recommended to use ros2-gbp to release ros2 packages.

It is definitely recommended, especially for Galactic and later stable releases, and is all but required for Rolling. I can assist with migrating the current repository contents to the ros2-gbp if a Rolling release is desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants