Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Xenial support #388

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Feb 21, 2020

Fixing an issue with Focal / Python 3.8:

Traceback (most recent call last):
  File "run_ros2_batch.py", line 32, in <module>
    sys.exit(main())
  File "/home/jenkins-agent/workspace/ci_linux/ros2_batch_job/__main__.py", line 153, in main
    if sys.platform.lower().startswith('linux') and platform.linux_distribution()[2] == 'xenial':
AttributeError: module 'platform' has no attribute 'linux_distribution'

Before: Build Status
After: Build Status

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added the bug Something isn't working label Feb 21, 2020
@dirk-thomas dirk-thomas self-assigned this Feb 21, 2020
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mildly curious whether the undefined attribute is an artifact of Focal's pre-release status or if it's something we can expect in the released version as well. But this solves the issue and no currently supported ROS 2 distribution supports Xenial.

@dirk-thomas
Copy link
Member Author

I'm mildly curious whether the undefined attribute is an artifact of Focal's pre-release status or if it's something we can expect in the released version as well.

The function has simply been removed in Python 3.8 after being deprecated since Python 3.5: https://docs.python.org/2/library/platform.html#platform.linux_distribution

@dirk-thomas dirk-thomas merged commit 44e79e1 into master Feb 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/remove-xenial-support branch February 21, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants