Final batch of fixes for Noble support. #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clalancette
force-pushed
the
clalancette/proposed-arm64
branch
2 times, most recently
from
3d21fd3
to
decbba6
Compare
clalancette
force-pushed
the
clalancette/proposed-arm64
branch
4 times, most recently
from
7a74a8d
to
cbb451a
Compare
|
Here's new CI, now that we think flake8 is fixed upstream:
|
Since we now depend on having updated apt packages, make sure we invalidate before all of the installation. This ensures we have up-to-date packages. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
The flake8 packages we need have finally landed in the normal noble repositories, so we no longer need the hack. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
They will automatically get pulled in by the development packages. This works around a potential problem on Noble aarch64 where the package names are now different because of the t64 changes. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
force-pushed
the
clalancette/proposed-arm64
branch
from
c05872d
to
aa93cc7
Compare
clalancette
changed the title
|
Here's a bunch of different CI to validate this change: Rolling on Noble:
Rolling on Jammy:
Iron on Jammy:
Humble on Jammy:
|
nuclearsandwich
approved these changes
Apr 16, 2024
|
I'm going to go ahead and merge this one in. Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this batch of fixes, we can now successfully build Rolling on Noble. See the individual commits for more information about why we need each of the changes.