Interface packages should fully <depend> on the interface packages that they depend on #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at they depend on Signed-off-by: Michael X. Grey <grey@openrobotics.org>
|
CI:
|
|
New CI with the build farm not ignoring packages involved in this PR:
|
|
The GitHub-run PR check failure is an exception in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the interface packages are missing a
<build_export_depend>tag for the interface packages that they depend on. The build export dependency is important because downstream packages need to know about the upstream interface dependencies at build time, e.g. to have access to the headers of the upstream interface packages. The lack of this tag made it impossible forrosidl_generator_rsto correctly identify the build dependency tree for the message packages.But also, adding
<build_export_depend>onto the already existing<build_depend>and<exec_depend>tags is the same as just specifying the<depend>tag, so this PR simplifies all the depend tags to just<depend>.