Move the find_package statements for BUILD_TESTING #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_add_gtest statement Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
sloretz
requested changes
Mar 31, 2022
sensor_msgs/CMakeLists.txt
Outdated
| @@ -79,6 +79,10 @@ if(cpp_typesupport_target) | |||
| ament_export_targets(export_${PROJECT_NAME}) | |||
|
|
|||
| if(BUILD_TESTING) | |||
| find_package(ament_cmake_gtest REQUIRED) | |||
| find_package(ament_lint_auto REQUIRED) | |||
| ament_lint_auto_find_test_dependencies() | |||
There was a problem hiding this comment.
I think only the find_package(ament_cmake_gtest) line should be moved. The linter tests can be run without the C++ typesupport target.
clalancette
requested changes
Mar 31, 2022
Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
clalancette
approved these changes
Mar 31, 2022
|
CI:
And a special CI, only building against CycloneDDS (which should trigger the original bug):
|
|
All right, this is all happy, so merging. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The find_package statements should be before the use of the ament_gtest statement.
Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org