Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast to uint32_t for pointcloud2 resize method #195

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

tonylitianyu
Copy link
Contributor

cast size_t to uint32_t to resolve msbuild warning

Signed-off-by: tonylitianyu tonylitianyu@gmail.com

Signed-off-by: tonylitianyu <tonylitianyu@gmail.com>
@gbiggs
Copy link
Member

gbiggs commented Jun 7, 2022

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@jacobperron
Copy link
Member

jacobperron commented Jun 8, 2022

@gbiggs I think there was a typo in your CI build args. (edit: common_interfaces -> sensor_msgs)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Signed-off-by: tonylitianyu <tonylitianyu@gmail.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks. Please make sure to run CI on this with --packages-above sensor_msgs, and also to run Windows Debug CI.

@jacobperron
Copy link
Member

Testing above sensor_msgs;

Windows Debug; Build Status

@tonylitianyu
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 37ebe90 into ros2:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants