Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image_tools should start with reliable policy #411

Merged
merged 1 commit into from
Nov 11, 2019
Merged

image_tools should start with reliable policy #411

merged 1 commit into from
Nov 11, 2019

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Oct 25, 2019

std::map sorts keys internally, so the first key is best_effort instead of the first inserted reliable. The QoS demo expects cam2image and showimage to start with reliable QoS.

@sloretz
image_tools should start with reliable policy
76a57fa 
std::map sorts keys internally, so the first key is `best_effort`
instead of the first-inserted `reliable`. The QoS demo expects it to
start in reliable.

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
@sloretz sloretz added the bug Something isn't working label Oct 25, 2019
@sloretz
Copy link
Contributor Author

sloretz commented Oct 26, 2019 •
edited
Loading

CI (testing just image_tools)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz added this to In progress in Eloquent via automation Oct 26, 2019
Eloquent automation moved this from In progress to Reviewer approved Nov 11, 2019
@sloretz sloretz merged commit 128b5ee into master Nov 11, 2019
Eloquent automation moved this from Reviewer approved to Done Nov 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the sloretz/image_tools_reliable branch November 11, 2019 21:21
@Karsten1987 Karsten1987 mentioned this pull request Nov 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
Eloquent
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sloretz @mjcarroll @jacobperron