Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a demo for the new ParameterEventHandler class #486

Merged
merged 5 commits into from
Mar 25, 2021

Conversation

mjeronimo
Copy link
Contributor

This demo depends on the following functionality: ros2/rclcpp#829, which must be integrated before this PR.

Signed-off-by: Michael Jeronimo michael.jeronimo@openrobotics.org

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
…iews

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
@mjeronimo mjeronimo changed the title [WIP] Add a demo for the new ParameterEventHandler class Add a demo for the new ParameterEventHandler class Mar 4, 2021
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjeronimo
Copy link
Contributor Author

@ros-pull-request-builder retest this please

The demo is interactive with the user.

Also, remove explicit calls to remove callbacks, since this will
happen automatically.

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
@mjeronimo
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjeronimo
Copy link
Contributor Author

Merging since the CI is passing and the PR builder issues were there previously (see https://build.ros2.org/view/Rdev/job/Rdev__demos__ubuntu_focal_amd64/28/).

@mjeronimo mjeronimo merged commit ea2845d into master Mar 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the mjeronimo/parameter-events-demo-cpp branch March 25, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants