Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add type masquerading demos" #520

Merged
merged 1 commit into from
May 17, 2021
Merged

Revert "Add type masquerading demos" #520

merged 1 commit into from
May 17, 2021

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented May 17, 2021 •
edited by clalancette
Loading

Reverts #482

Fixes #520.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette mentioned this pull request May 17, 2021
Closed
@clalancette
Copy link
Contributor

I'm going to go ahead and merge this one to unblock CI.

@clalancette clalancette merged commit 61aeb28 into master May 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the revert-482-audrow/type-masquerading branch May 17, 2021 12:37
wjwwood added a commit that referenced this pull request May 18, 2021
@wjwwood
Revert "Revert "Add type masquerading demos (#482)" (#520)"
2d76c37 
This reverts commit 61aeb28.
@wjwwood wjwwood mentioned this pull request May 18, 2021
Merged
audrow pushed a commit that referenced this pull request May 18, 2021
@wjwwood
Revert "Revert "Add type masquerading demos"" (#521)
ae639cd 
* Revert "Revert "Add type masquerading demos (#482)" (#520)"

This reverts commit 61aeb28.

* revert out-of-date changes to intra process demo

Signed-off-by: William Woodall <william@osrfoundation.org>
@jasonbeach
Copy link

What was the issue (why was this reverted)?

@clalancette
Copy link
Contributor

What was the issue (why was this reverted)?

At the time it broke CI, but we have had this back in the code (via #521) since May of 2021.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wjwwood @clalancette @jasonbeach