Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type masquerading demos #482

Merged
merged 9 commits into from May 15, 2021
Merged

Add type masquerading demos #482

merged 9 commits into from May 15, 2021

Conversation

audrow
Copy link
Member

@audrow audrow commented Jan 21, 2021

This PR shows how type masquerading could be for images and with an intraprocess pub/sub.

Currently, type masquerading isn't implemented.

This is part of the Type Masquerading project.

@audrow audrow added the enhancement New feature or request label Jan 21, 2021
@audrow audrow requested a review from wjwwood January 21, 2021 19:29
@audrow audrow self-assigned this Jan 21, 2021
@audrow audrow changed the title Add type masquerading examples Add type masquerading demos Jan 21, 2021
@wjwwood wjwwood mentioned this pull request Feb 9, 2021
Merged
@wjwwood wjwwood mentioned this pull request Feb 23, 2021
Merged
5 tasks
@wjwwood wjwwood changed the base branch from master to type_adaption April 28, 2021 23:00
@wjwwood wjwwood marked this pull request as ready for review April 29, 2021 22:07
@delete-merged-branch delete-merged-branch bot deleted the branch master May 7, 2021 04:34
audrow and others added 6 commits May 11, 2021 15:51
@audrow @wjwwood
Use cv::Map instead of sensor_messages::Image
17ca47c 
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
@audrow @wjwwood
Use int32_t instead of std_msgs::Int32
78506e3 
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
@audrow @wjwwood
Replace existing files with type masquerading demos
7dd4860 
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
@wjwwood
wip updating image_tools demo
9795b4c 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
refactor image_tools demo to use cv::Mat TypeAdapter
3a8bf68 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
update image_tools library so it can be reused outside if desired
07debb3 
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood assigned wjwwood and audrow and unassigned audrow May 11, 2021
wjwwood
wjwwood approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will wait for @audrow to review and run CI.

audrow
audrow commented May 13, 2021
View reviewed changes
Copy link
Member Author

@audrow audrow left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve this PR because I opened the PR.

These changes look good to me with green CI.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood
Copy link
Member

wjwwood commented May 13, 2021

Looks like we'll have to investigate the opencv related failure.

@paudrow
Store is big endian in ROSCvMatContainer
15f7022 
Signed-off-by: Audrow Nash <audrow@hey.com>
@wjwwood wjwwood mentioned this pull request May 13, 2021
Merged
@wjwwood
Copy link
Member

wjwwood commented May 13, 2021

I opened ros2/rclcpp#1674 to address the GCC issue. @audrow can you run CI? I know you did something odd to run it before, IIRC.

@wjwwood
uncrustify
9e4d35e 
Signed-off-by: William Woodall <william@osrfoundation.org>
@audrow
Copy link
Member Author

audrow commented May 14, 2021

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@paudrow
Fix cpplint errors
635fa66 
Signed-off-by: Audrow Nash <audrow@hey.com>
@audrow
Copy link
Member Author

audrow commented May 14, 2021 •
edited

Testing this package and rclcpp:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@audrow audrow changed the base branch from type_adaption to master May 14, 2021 20:13
@wjwwood wjwwood merged commit 29f74d7 into master May 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the audrow/type-masquerading branch May 15, 2021 00:54
wjwwood added a commit that referenced this pull request May 17, 2021
@wjwwood
Revert "Add type masquerading demos (#482)"
e35dc15 
This reverts commit 29f74d7.
@wjwwood wjwwood mentioned this pull request May 17, 2021
Merged
clalancette pushed a commit that referenced this pull request May 17, 2021
@wjwwood
Revert "Add type masquerading demos (#482)" (#520)
61aeb28 
This reverts commit 29f74d7.
wjwwood added a commit that referenced this pull request May 18, 2021
@wjwwood
Revert "Revert "Add type masquerading demos (#482)" (#520)"
2d76c37 
This reverts commit 61aeb28.
audrow pushed a commit that referenced this pull request May 18, 2021
@wjwwood
Revert "Revert "Add type masquerading demos"" (#521)
ae639cd 
* Revert "Revert "Add type masquerading demos (#482)" (#520)"

This reverts commit 61aeb28.

* revert out-of-date changes to intra process demo

Signed-off-by: William Woodall <william@osrfoundation.org>
@ZhenshengLee ZhenshengLee mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

@wjwwood wjwwood

@audrow audrow

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@audrow @wjwwood @paudrow