Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Add type masquerading demos"" #521

Merged
merged 2 commits into from
May 18, 2021

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented May 18, 2021

Reverts #520

wjwwood and others added 2 commits May 18, 2021 15:01
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood
Copy link
Member Author

wjwwood commented May 18, 2021

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood wjwwood requested a review from audrow May 18, 2021 22:10
@wjwwood wjwwood self-assigned this May 18, 2021
Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI!

@wjwwood

This comment has been minimized.

@wjwwood
Copy link
Member Author

wjwwood commented May 18, 2021

Rpr is expected to fail until a new rclcpp release is made.

@audrow audrow merged commit ae639cd into master May 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the revert-520-revert-482-audrow/type-masquerading branch May 18, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants