Update python nodes SIGINT handling #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
hidmic
reviewed
Nov 9, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
delete-merged-branch
bot
deleted the
ivanpauno/shutdown-asynchronously-when-sigint
branch
jacobperron
reviewed
Aug 3, 2022
| node.destroy_node() | ||
| rclpy.shutdown() | ||
| except ExternalShutdownException: | ||
| sys.exit(1) |
There was a problem hiding this comment.
Sorry to comment on an old ticket, but why are we exiting with error code 1? IIUC, ExternalShutdownException is something we should expect as part of the normal shutdown sequence here.
It seems to me that all of the demos should be updated to look like,
try:
rclpy.spin(node)
except (KeyboardInterrupt, ExternalShutdownException):
pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ros2/rclpy#844.