Dramatically speed up the demo_nodes_cpp tests #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
force-pushed
the
clalancette/speed-up-demo-nodes-cpp-tests
branch
from
8bc42bc
to
49db06b
Compare
|
CI (with
|
mjcarroll
reviewed
Jun 12, 2023
That is, just wait long enough for the process to have an exit code. On its own, this change doesn't actually make a huge difference to the test times, but when combined with some of the upcoming changes it should make a significant reduction. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Make them use underscores for the member variables, and make those member variables private. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
That way we can configure some of the demos to be much more speedy, while retaining their default behavior. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
IF the one-shot parameter is set, then it will quit after receiving the first request. Useful for testing. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
This can shorten our tests dramatically. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
force-pushed
the
clalancette/speed-up-demo-nodes-cpp-tests
branch
from
49db06b
to
2d802db
Compare
|
To try and get this out of draft, here is normal CI for this PR:
And here is Windows run with
|
|
After comparing the test failures before and after on Windows, I think it is fair to say that these failures aren't caused by this PR. That is, this PR seems to make no difference there (we should debug those failures separately). So I'm actually going to take this out of draft status so we can review and get this in. |
clalancette
requested review from
adityapande-1995,
audrow and
mjeronimo
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to speed up the demo_nodes_cpp tests. On my local machine, prior to this PR, the tests took ~5 minutes to run. After this PR, they take ~1 minute.
To achieve this, this PR does a number of different things:
talker,listener,content_filtering_publisher, andadd_two_ints_serverto control their behavior. The major goal here is to keep their default behavior the same, but add in alternate modes to dramatically speed up tests.The individual commits have more information about each change and why I made it.
This is still a draft because I want to run extensive CI on it, particularly on Windows.