Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long sleep time for the execution of each demo test case #628

Closed
Barry-Xu-2018 opened this issue May 16, 2023 · 0 comments · Fixed by #641
Closed

Long sleep time for the execution of each demo test case #628

Barry-Xu-2018 opened this issue May 16, 2023 · 0 comments · Fixed by #641

Comments

@Barry-Xu-2018
Copy link
Contributor

Barry-Xu-2018 commented May 16, 2023

Bug report

Required Info:

  • Operating System:
    • Ubuntu 22.04
  • Installation type:
    • source code
  • Version or commit hash:
    • rolling branch
  • DDS implementation:
    • Fast-RTPS
  • Client library (if applicable):
    • rclcpp

Steps to reproduce issue

$ colcon test --packages-select demo_nodes_cpp --event-handlers console_direct+

Expected behavior

Not spend much time for each test

Actual behavior

Consumed time for each test is more than 5 second
e.g.

     Start  1: test_tutorial_content_filtering_publisher_content_filtering_subscriber__rmw_cyclonedds_cpp
      ...
1: Ran 1 test in 31.032s
      Start  2: test_tutorial_list_parameters_async__rmw_cyclonedds_cpp
      ...
2: Ran 1 test in 5.031s
      Start  3: test_tutorial_list_parameters__rmw_cyclonedds_cpp
      ...
3: Ran 1 test in 5.036s
      Start  4: test_tutorial_parameter_events_async__rmw_cyclonedds_cpp
      ...
4: Ran 1 test in 5.237s
      Start  5: test_tutorial_parameter_events__rmw_cyclonedds_cpp
      ...
5: Ran 1 test in 5.034s
      Start  6: test_tutorial_set_and_get_parameters_async__rmw_cyclonedds_cpp
      ...
6: Ran 1 test in 5.034s
      Start  7: test_tutorial_set_and_get_parameters__rmw_cyclonedds_cpp
      ...
7: Ran 1 test in 5.038s
      Start  8: test_tutorial_matched_event_detect__rmw_cyclonedds_cpp
      ...
8: Ran 1 test in 5.042s
      Start  9: test_tutorial_use_logger_service__rmw_cyclonedds_cpp
      ...
9: Ran 1 test in 5.838s
      Start 10: test_tutorial_talker_listener__rmw_cyclonedds_cpp
      ...
10: Ran 1 test in 6.032s
      Start 11: test_tutorial_add_two_ints_server_add_two_ints_client__rmw_cyclonedds_cpp
      ...
11: Ran 1 test in 5.043s
      Start 12: test_tutorial_add_two_ints_server_add_two_ints_client_async__rmw_cyclonedds_cpp
      ...
12: Ran 1 test in 5.031s

Additional information

Current test framework includes sleep operation

# TODO(hidmic): either make the underlying executables resilient to
# interruptions close/during shutdown OR adapt the testing suite to
# better cope with it.
import time
time.sleep(5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant