Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[demo_nodes_cpp] some readme and executable name fixups #678

Merged
merged 2 commits into from
May 6, 2024
Merged

[demo_nodes_cpp] some readme and executable name fixups #678

merged 2 commits into from
May 6, 2024

Conversation

mikaelarguedas
Copy link
Member

Noticed when testing osrf/ros2_test_cases#1197

@mikaelarguedas
more typos and update to console outputs
55fe927 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas
[even_parameter_node] fix executable name and console output
174b5f3 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas mentioned this pull request May 5, 2024
Closed
@iam-shanmukha
Copy link

iam-shanmukha commented May 5, 2024 •
edited

Hi, This also provides fix for osrf/ros2_test_cases#1196

Corresponding Comment (4-May-2024):

osrf/ros2_test_cases#1196 (comment)

mjcarroll
mjcarroll approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, doc changes only.

fujitatomoya
fujitatomoya approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

ahcorde
ahcorde approved these changes May 6, 2024
View reviewed changes
Copy link

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit aa8df89 into rolling May 6, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the demo_nodes_cpp_typo branch May 6, 2024 20:28
@ahcorde
Copy link

ahcorde commented May 6, 2024

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link

mergify bot commented May 6, 2024 •
edited

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 6, 2024
@mikaelarguedas @mergify
[demo_nodes_cpp] some readme and executable name fixups (#678)
b9ead56 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
(cherry picked from commit aa8df89)
@mergify mergify bot mentioned this pull request May 6, 2024
Merged
ahcorde pushed a commit that referenced this pull request May 6, 2024
@mergify @mikaelarguedas
[demo_nodes_cpp] some readme and executable name fixups (#678) (#688)
853701b 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
(cherry picked from commit aa8df89)

Co-authored-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@mjeronimo mjeronimo Awaiting requested review from mjeronimo mjeronimo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikaelarguedas @iam-shanmukha @ahcorde @mjcarroll @fujitatomoya