Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[image_tools] Use ROS parameters instead of regular CLI arguments #398

Merged
merged 6 commits into from
Oct 17, 2019
Merged

[image_tools] Use ROS parameters instead of regular CLI arguments #398

merged 6 commits into from
Oct 17, 2019

Commits on Oct 15, 2019

  1. [image_tools] Use ROS parameters instead of regular CLI arguments 

    Using of ROS parameters make the code a little tidier, though a little more verbose on the command-line.
IMO, it seems like a good way to demonstrate best practices as well.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    97d3a56 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Add help option 

    Display a help message and exit if the non-ros flag '-h' or '--help' is given.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    da736d0 View commit details
    Browse the repository at this point in the history

  2. Fix lint 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    7a70edd View commit details
    Browse the repository at this point in the history

  3. Refactor showimage 

    Really, the 'execute' method is doing initialization.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    6bc4383 View commit details
    Browse the repository at this point in the history

  4. Refactor cam2image to use timer 

    Avoid blocking on construction by using a timer for the main loop.
This resolves an issue where we are unable to query parameters from the command line.
I've also moved initialization logic into it's own method, similar to showimage.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    513d5ce View commit details
    Browse the repository at this point in the history

  5. Update test 

    Use Node actions and parameters.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    509e01a View commit details
    Browse the repository at this point in the history