-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ambigulity: unknown type name 'nullptr_t' #528
Conversation
Signed-off-by: xwnb <xwnbzc@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems reasonable to me. According to https://en.cppreference.com/w/cpp/types/nullptr_t, nullptr_t
comes from the cstddef
header. Can you please add a #include <cstddef>
to each of the files as well?
This header is contained by other stardand header, such as |
While that is true, I always like to include what I'm using. You never know when a downstream header will change. So please add it in. |
Can you please sign your second commit? That will allow our DCO bot to pass. Once that is done, I can run CI here. Thanks. |
I am trying do push the new commit. But it is a connect fatal. I do not know why. Can you offer me some help?
|
Hm, I don't know, sorry. I've reset this back to the old commit, then you can try pushing without |
Signed-off-by: xwnb <xwnbzc@outlook.com>
Works. Thanks @clalancette 👍 |
Signed-off-by: xwnb xwnbzc@outlook.com
When build
ros2/demos image_tools on
Ubuntu, a compile error occurred (usingclang
). Looks like the nullptr_t causes ambiguous betweenstd::nullptr_t
andcv::nullptr_t
.error:
compile command:
system version:
clang version: