Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage of spin_until_future_complete #556

Closed
wants to merge 1 commit into from
Closed

Update usage of spin_until_future_complete #556

wants to merge 1 commit into from

Conversation

hliberacki
Copy link

Use spin_until_complete instead of deprecated spin_until_future_complete

Signed-off-by: Hubert Liberacki hliberacki@gmail.com

@hliberacki
Copy link
Author

Due to changes in RCLCPP, made in ros2/rclcpp#1874 PR.

audrow
audrow approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@audrow
Copy link
Member

audrow commented Mar 31, 2022

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@hliberacki
Copy link
Author

@audrow ros2/rclcpp#1874 (comment) Passing CI with all related PRs linked and build together.

@hliberacki
Use spin_until_complete instead of deprecated `spin_until_future_co…
f880a52 
…mplete`

Signed-off-by: Hubert Liberacki <hliberacki@gmail.com>
@clalancette clalancette mentioned this pull request Jun 24, 2022
Merged
@fujitatomoya fujitatomoya mentioned this pull request Jun 24, 2022
Closed
@audrow audrow changed the base branch from master to rolling June 28, 2022 14:18
@fujitatomoya fujitatomoya mentioned this pull request Jan 23, 2023
Open
@christophebedard christophebedard mentioned this pull request Apr 2, 2024
Closed
@christophebedard
Copy link
Member

I've opened #669 to replace this PR.

@christophebedard
Copy link
Member

This can be closed, see #669 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audrow audrow audrow approved these changes

@SteveMacenski SteveMacenski SteveMacenski approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hliberacki @audrow @christophebedard @SteveMacenski @fujitatomoya @clalancette