-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type adaption example #300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
reviewed
Jan 25, 2021
rclcpp/topics/minimal_subscriber/member_function_type_masquerading.cpp
Outdated
Show resolved
Hide resolved
rclcpp/topics/minimal_publisher/member_function_type_masquerading.cpp
Outdated
Show resolved
Hide resolved
5 tasks
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
audrow
force-pushed
the
audrow/type-masquerading
branch
from
April 13, 2021 23:34
9e33051
to
300d5d9
Compare
wjwwood
reviewed
Apr 29, 2021
rclcpp/topics/minimal_publisher/member_function_with_type_adapter.cpp
Outdated
Show resolved
Hide resolved
wjwwood
reviewed
Apr 29, 2021
rclcpp/topics/minimal_publisher/member_function_with_type_adapter.cpp
Outdated
Show resolved
Hide resolved
rclcpp/topics/minimal_subscriber/member_function_with_type_adapter.cpp
Outdated
Show resolved
Hide resolved
rclcpp/topics/minimal_subscriber/member_function_with_type_adapter.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
wjwwood
approved these changes
May 11, 2021
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows how type adaption could be for publishers and subscribers.
This PR relies on ros2/rclcpp#1557.
This is part of the Type Masquerading project.