use wait_for_service to make examples less flaky #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2016
wjwwood
added
in review
| foreach(example_test ${example_tests}) | ||
| set(example_tests_to_test ${example_tests}) | ||
| # TODO(wjwwood): recombine with example_tests this when fastrtps supports wait_for_service. | ||
| if("${rmw_implementation} " STREQUAL "rmw_fastrtps_cpp ") |
There was a problem hiding this comment.
Since we are using CMake 3.5 now please avoid the trailing spaces as well as the quotes and explicit variable expansion if the variable is know to exist:
if(rmw_implementation STREQUAL "rmw_fastrtps_cpp")
|
Beside the comment +1 |
can be reenable when fastrtps supports wait_for_service
wjwwood
force-pushed
the
wait_for_service2
branch
from
b7bc1a3
to
6a9ec4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/ros2#215