Rclcpp action examples #220

sloretz · 2018-12-06T17:09:55Z

This is #216 with an extra commit to remove the python action examples

Contains a non-composable implementation with global variables.

Contains a non-composable implementation.

Seed the fibonacci sequence and remove const.

Forgot to increment in Fibonacci sequence loop.

Return goal handle (containing future) when sending a goal.

jacobperron

LGTM with green CI

sloretz · 2018-12-07T02:58:38Z

CI

Linux
Linux-aarch64
macOS
Windows

jacobperron and others added 30 commits November 19, 2018 22:04

Add minimal_action_server package

2e12424

Contains a non-composable implementation with global variables.

Add minimal_action_client package

4cfc153

Contains a non-composable implementation.

Add action client example with feedback

9bf34b9

async python action client example

66f1b60

goal -> future

99feac3

fibb -> fib"

6d92ab2

Syncronous action client example

826d4c1

No break statement

81dc852

Update client examples to use separate rcl_action package

49f679c

Add ClientGoalHandle to action client examplesj

a4eddad

Add action client with cancel example

a83cb0c

python non-composable server example

294e23e

[wip] Update action server cpp example

4729e98

remove unnecessary event

53834fd

create_action_server -> ActionServer

a5e7990

missing paren

7a64f12

Add example of multiple goals in parallel

8c574c1

No need for lock

b3a48cb

Reentrant callback group for execute

d64be0f

create_action_client -> ActionClient

b7bd576

Fix copyright date

16821ba

)

b5a236e

-)

a002982

Refactor action server cpp example

ed2757d

Fix action server cpp example

13e80b2

Seed the fibonacci sequence and remove const.

Fix action server cpp example

bd92ca8

Forgot to increment in Fibonacci sequence loop.

Syntax fixes

33a517c

node -> self

ffbeaaf

handle cb returns accept or reject

54fb427

Update action client cpp example

94293f2

Return goal handle (containing future) when sending a goal.

sloretz and others added 17 commits November 19, 2018 22:04

Preempt goals

f19c02a

whitespace removal

3a23ede

execute returns result

131b896

Add missing resources

5801a85

Syntax error

320933f

Add rcl_action dependency

1adbaef

Update maintainer

f1ab2b4

Use goal message getter and alias ResultResponse type

426c1db

Make minimal_action_server work with rclcpp_action

75e3f7d

Client and server communicate

1c11d53

handle_execute -> handle_accepted

eb6e86e

Check if goal was rejected by server

e8a896e

Update example to check result

abb360f

action client cancel example C++ works

913ef8e

misc changes to compile

388a3e8

misc client api changes

39c23e6

Remove python examples

ed7019d

sloretz added this to the crystal milestone Dec 6, 2018

sloretz self-assigned this Dec 6, 2018

sloretz added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Dec 6, 2018

jacobperron approved these changes Dec 6, 2018

View reviewed changes

sloretz mentioned this pull request Dec 6, 2018

Check in action module if action service ros2/ros2cli#163

Merged

Wait for action server

97a4bfe

jacobperron approved these changes Dec 7, 2018

View reviewed changes

sloretz merged commit 245ae8d into master Dec 7, 2018

sloretz deleted the rclcpp_action_examples branch December 7, 2018 03:38

sloretz removed the in review Waiting for review (Kanban column) label Dec 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rclcpp action examples #220

Rclcpp action examples #220

sloretz commented Dec 6, 2018

jacobperron left a comment

sloretz commented Dec 7, 2018

Rclcpp action examples #220

Rclcpp action examples #220

Conversation

sloretz commented Dec 6, 2018

jacobperron left a comment

Choose a reason for hiding this comment

sloretz commented Dec 7, 2018