Remove stray semicolon causing compiler error when using -Werror=pedantic #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcarroll
approved these changes
May 16, 2019
|
Sorry, this must have slipped through. Does it generally make sense to have the |
|
I think it would make sense for the ROS code to have the most restrictive compiler settings like pedantic enabled so that the code could be used by any team with their own local policy regarding compiler flags. Otherwise, when the consumers of the code are using more restrictive settings you risk compilation errors (as in this case). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No semi required after class method.