Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port geometry2 metapackage to ROS 2 to be able to use it in variants #184

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Port geometry2 metapackage to ROS 2 to be able to use it in variants #184

merged 2 commits into from
Oct 22, 2019

Conversation

mikaelarguedas
Copy link
Member

@mikaelarguedas mikaelarguedas commented Oct 21, 2019 •
edited
Loading

No description provided.

@mikaelarguedas
comvert to package format 2
6c0f6a6 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas
port geometry2 metapackage to ROS 2
84afff3 
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas changed the title Geometry2 metapackage Port geometry2 metapackage to ROS 2 to be able to use it in variants Oct 21, 2019
clalancette
clalancette approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikaelarguedas Awesome, thanks for doing this!

@mikaelarguedas mikaelarguedas mentioned this pull request Oct 21, 2019
Merged
@mikaelarguedas
Copy link
Member Author

no worries 👍, had a build failure due to missing tf2_sensor_msgs package so I figured I'd fix it while it rebuilds

@clalancette
Copy link
Contributor

CI up to geometry2:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette merged commit eebc783 into ros2:ros2 Oct 22, 2019
@mikaelarguedas mikaelarguedas deleted the geometry2_metapackage branch October 22, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikaelarguedas @clalancette @tfoote