installed python tf2_geometry_msgs #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ahcorde
commented
Dec 17, 2019
ahcorde
commented
- installed python tf2_geometry_msgs
- Added TODO to install test once this PR port python_orocos_kdl to ros2 orocos_kinematics_dynamics#4 is merged
ahcorde
force-pushed
the
ahcorde/port/tf2_geometry_msgs
branch
from
f30389d
to
368b77a
Compare
clalancette
reviewed
Dec 17, 2019
| @@ -1 +1 @@ | |||
| from tf2_geometry_msgs import * | |||
| from .tf2_geometry_msgs import * | |||
There was a problem hiding this comment.
I'm not opposed to this change, but I'm surprised it is needed. Is it?
There was a problem hiding this comment.
there is code inside tf2_geometry_msgs.py that needs to run when the module is imported. I didn't find another way to do it
There was a problem hiding this comment.
All right, that's fine. I'll approve.
clalancette
approved these changes
Dec 17, 2019
|
ahcorde
added a commit
that referenced
this pull request
Jan 23, 2020
* installed python tf2_geometry_msgs * ported tf2_geometry_msgs python test * tf2_geometry_msgs test wroking
ahcorde
added a commit
that referenced
this pull request
Feb 12, 2020
* installed python tf2_geometry_msgs * ported tf2_geometry_msgs python test * tf2_geometry_msgs test wroking
ahcorde
added a commit
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.