-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting tf2_sensor_msgs in C++ (#2) #75
Conversation
Mmh. I don't actually see where tf2_sensor_msgs is being built in that output. The issues appear to me to be upstream of this. Thoughts? |
It's here: https://ci.ros2.org/job/ci_linux/5353/consoleFull#console-section-378 . The reason you don't see "much" being done is because this looks like a header-only library in C++, so all it is doing is installing the header file and surrounding infrastructure. The problems that are causing this to be yellow are indeed elsewhere in the codebase, so we can ignore those. Assuming the other builds finish with the same set of errors, I'll be happy to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yellow CI is because of other problems in the codebase unrelated to this PR.
Awesome, merge as you see fit |
Done, thanks for the contribution. |
<run_depend>tf2</run_depend> | ||
<run_depend>python_orocos_kdl</run_depend> | ||
<depend>cmake_modules</depend> | ||
<depend>Eigen3</depend> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure capital Eigen3
is defined in rosdistro.
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
tf2_sensor_msgs: Cannot locate rosdep definition for [Eigen3]
@clalancette , was this migration intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruffsl I think you're right, I looked at rosdistro and it looks like eigen
leads to eigen3
debians
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't remember at all, sorry. However, this package is released into Bouncy, so I'm pretty sure what is currently in there works one way or another.
@clalancette Lets try this again 馃挴