Ensure that shutdown event is handled correctly #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a potential race condition in bewteen when the shutdown event is emitted and the rest of the shutdown handling code. This introduces an additional await to ensure that the event is emitted before proceeding.
|
mjcarroll
added
in review
|
wjwwood
approved these changes
Nov 15, 2018
| @@ -57,7 +57,7 @@ def _assert_type_error_creating_node(self, *, parameters=None, remappings=None): | |||
| def test_launch_invalid_node(self): | |||
| """Test launching an invalid node.""" | |||
| node_action = launch_ros.actions.Node( | |||
| package='nonexistent_package', node_executable='node', output='screen'), | |||
| package='nonexistent_package', node_executable='node', output='screen') | |||
There was a problem hiding this comment.
We think this was always causing a subtle bug (node_action was a single item tuple rather than just a single item), but was being hidden because the tests didn't complete due to the race condition being fixed in this pull request.
|
And the windows rebuild after umlaut-gate: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a potential race condition in bewteen when the shutdown event
is emitted and the rest of the shutdown handling code. This introduces
an additional await to ensure that the event is emitted before
proceeding.