convert function names to snake_case #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports logging messages from multiple processes and modules to the screen, a common log file, or both. LaunchLogger is a singleton and when it is first instantiated a log file is created of the form 'DATETIME-launch-HOSTNAME-PID.log'. Messages sent to the screen or the log file will have the format 'TIME [LEVEL] NAME: MESSAGE'.
The timestamp in the screen format is optional.
Also extends LaunchLogger interface. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
- Fix style and documentation issues. - Removes dangling TODO. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
This makes it more consistent with the rest of the code in launch. Signed-off-by: William Woodall <william@osrfoundation.org>
Merged
hidmic
force-pushed
the
104-launch-logger
branch
3 times, most recently
from
2ab223f
to
9872792
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more consistent with the rest of the code in launch, see my review of #145 for more discussion.