Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parsing methods for SetEnviromentVariable and UnsetEnviromentVariable #272

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Add parsing methods for SetEnviromentVariable and UnsetEnviromentVariable #272

merged 2 commits into from
Jul 16, 2019

Conversation

ivanpauno
Copy link
Member

Follow up of #226.

@ivanpauno
Add parsing methods for SetEnviromentVariable UnsetEnviromentVariable
f6f583d 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added enhancement New feature or request in review Waiting for review (Kanban column) labels Jul 16, 2019
@ivanpauno ivanpauno requested a review from hidmic July 16, 2019 12:50
@ivanpauno ivanpauno self-assigned this Jul 16, 2019
@ivanpauno ivanpauno mentioned this pull request Jul 16, 2019
Merged
hidmic
hidmic approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for a couple nits.

launch_xml/test/launch_xml/test_set_env.py Show resolved Hide resolved
launch_xml/test/launch_xml/test_unset_env.py Show resolved Hide resolved
@ivanpauno
Address per review comments
e586ed7 
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Member Author

CI (up to launch, launch_xml, launch_yaml, launch_ros, test_launch_ros, only fastrtps):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit b6ed340 into master Jul 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/set-unset-env-var-paring-methods branch July 16, 2019 18:13
piraka9011 pushed a commit to aws-ros-dev/launch that referenced this pull request Aug 16, 2019
@ivanpauno @piraka9011
Add parsing methods for SetEnviromentVariable and UnsetEnviromentVari…
cd013a4 
…able (ros2#272)

Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@wjwwood wjwwood wjwwood approved these changes

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanpauno @wjwwood @hidmic