Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve libyaml warning when loading parameters from file #161

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Resolve libyaml warning when loading parameters from file #161

merged 1 commit into from
Jul 23, 2020

Conversation

dawonn-haval
Copy link
Contributor

Fixes #160

@dawonn-haval
Resolve libyaml warning when loading parameters from file
c79f526 
Fixes ros2#160

Signed-off-by: Dereck Wonnacott <dereck.wonnacott@havalus.com>
@dirk-thomas dirk-thomas self-requested a review July 23, 2020 17:52
@dirk-thomas
Copy link
Member

Thanks for the patch.

CI testing launch_ros and above (with only Fast DDS):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status (unrelated test failure)

@dirk-thomas dirk-thomas merged commit e121f6b into ros2:master Jul 23, 2020
@dirk-thomas dirk-thomas added this to Needs release in Rolling Ridley Jul 23, 2020
@dirk-thomas dirk-thomas added this to Proposed in Foxy Patch Release 2 via automation Jul 23, 2020
@dirk-thomas dirk-thomas moved this from Proposed to Needs backport in Foxy Patch Release 2 Jul 23, 2020
@dirk-thomas dirk-thomas added this to Needs Backport in Dashing Patch Release 8 Jul 23, 2020
@dirk-thomas dirk-thomas added this to Needs Backport in Eloquent Patch Release 2 Jul 23, 2020
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 2 Aug 7, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 3 via automation Aug 7, 2020
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 3 Aug 7, 2020
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 3 Oct 9, 2020
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 4 via automation Oct 9, 2020
@jacobperron jacobperron moved this from Proposed to Needs backport in Foxy Patch Release 4 Oct 9, 2020
jacobperron pushed a commit that referenced this pull request Nov 19, 2020
@dawonn-haval @jacobperron
Resolve libyaml warning when loading parameters from file (#161)
d08bfc7 
Fixes #160

Signed-off-by: Dereck Wonnacott <dereck.wonnacott@havalus.com>
@jacobperron jacobperron mentioned this pull request Nov 19, 2020
Merged
jacobperron pushed a commit that referenced this pull request Nov 19, 2020
@dawonn-haval @jacobperron
Resolve libyaml warning when loading parameters from file (#161)
4baf483 
Fixes #160

Signed-off-by: Dereck Wonnacott <dereck.wonnacott@havalus.com>
jacobperron pushed a commit that referenced this pull request Nov 19, 2020
@dawonn-haval @jacobperron
Resolve libyaml warning when loading parameters from file (#161)
e5a9323 
Fixes #160

Signed-off-by: Dereck Wonnacott <dereck.wonnacott@havalus.com>
@jacobperron jacobperron mentioned this pull request Nov 19, 2020
Merged
nuclearsandwich pushed a commit that referenced this pull request Nov 20, 2020
@dawonn-haval @nuclearsandwich
Resolve libyaml warning when loading parameters from file (#161)
25508f3 
Fixes #160

Signed-off-by: Dereck Wonnacott <dereck.wonnacott@havalus.com>
jacobperron added a commit that referenced this pull request Nov 20, 2020
@jacobperron @dawonn-haval
Resolve libyaml warning when loading parameters from file (#161) (#204)
be1a99c 
Fixes #160

Signed-off-by: Dereck Wonnacott <dereck.wonnacott@havalus.com>

Co-authored-by: Dereck Wonnacott <44446780+dawonn-haval@users.noreply.github.com>
jacobperron added a commit that referenced this pull request Nov 20, 2020
@jacobperron @dawonn-haval
Resolve libyaml warning when loading parameters from file (#161) (#202)
07c5216 
Fixes #160

Signed-off-by: Dereck Wonnacott <dereck.wonnacott@havalus.com>

Co-authored-by: Dereck Wonnacott <44446780+dawonn-haval@users.noreply.github.com>
@jacobperron jacobperron removed this from Needs backport in Foxy Patch Release 4 Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas Awaiting requested review from dirk-thomas

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Dashing Patch Release 8
Needs Backport
Eloquent Patch Release 2
Needs Backport
Rolling Ridley
Needs release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

calling yaml.load() without Loader=... is deprecated
2 participants
@dawonn-haval @dirk-thomas