Ensure load_composable_nodes respects condition #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Dec 8, 2022
methylDragon
force-pushed
the
ch3/bugfix-load-composable-nodes
branch
from
501ca0a
to
2abf5cc
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
ch3/bugfix-load-composable-nodes
branch
from
2abf5cc
to
c36c455
Compare
|
@ros-pull-request-builder retest this please! |
adityapande-1995
approved these changes
Dec 8, 2022
|
Can we backport this fix to humble? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #335 and #328
Description
It turns out that the
LoadComposableNodesaction ignores conditions. This is because it was meant to interact with composable node containers via the composition_interfaces/srv/LoadNode service, which has no concept of conditions.This means that the condition check has to happen prior to the population of service calls to make, which this PR adds.
I also added new tests to support the new behavior.