Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launch_ros.actions.Node parsing function #83

Merged
merged 3 commits into from
Oct 15, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Oct 8, 2019

Follow-up after #82. Fixes ros2/build_farmer#244.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from wjwwood October 8, 2019 23:41
@hidmic
Copy link
Contributor Author

hidmic commented Oct 8, 2019

CI up to launch_testing_ros and test_launch_ros:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Oct 11, 2019

So, test failures on Windows stem from path backslashes being escaped by launch frontend parsers.

We, @ivanpauno and I, think that having to escape backslashes when pure Windows paths want to be used in an XML launch file is fine, but being forced to specify paths in a platform specific way isn't. It turns launch files platform-specific. Actions should handle POSIX paths.

I'll open an issue to track this enhancement.

@hidmic
Copy link
Contributor Author

hidmic commented Oct 11, 2019

Alright, all green! @wjwwood @clalancette PTAL so I can merge.

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, other than the one comment

@wjwwood
Copy link
Member

wjwwood commented Oct 15, 2019

@hidmic any reason to not merge this?

@wjwwood wjwwood mentioned this pull request Oct 15, 2019
@hidmic
Copy link
Contributor Author

hidmic commented Oct 15, 2019

No reason. I didn't on Friday because of your last comment and the discussion it sparked.

Merging now!

@hidmic hidmic merged commit 3a3600d into master Oct 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/fix-node-parsing-function branch October 15, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new test failures on linux nightly
4 participants