-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix launch_ros.actions.Node parsing function #83
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
So, test failures on Windows stem from path backslashes being escaped by launch frontend parsers. We, @ivanpauno and I, think that having to escape backslashes when pure Windows paths want to be used in an XML launch file is fine, but being forced to specify paths in a platform specific way isn't. It turns launch files platform-specific. Actions should handle POSIX paths. I'll open an issue to track this enhancement. |
Alright, all green! @wjwwood @clalancette PTAL so I can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, other than the one comment
@hidmic any reason to not merge this? |
No reason. I didn't on Friday because of your last comment and the discussion it sparked. Merging now! |
Follow-up after #82. Fixes ros2/build_farmer#244.