Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document all variables set by this module #5

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jul 22, 2021

I was looking at this module because of ros2/rosidl_python#137, and I found a couple variables it sets are undocumented. I also added PYTHON_SOABI to the list of variables find_package_handle_standard_args() thinks are required because it appears to be one.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the documentation Improvements or additions to documentation label Jul 22, 2021
@sloretz sloretz self-assigned this Jul 22, 2021
@sloretz
Copy link
Contributor Author

sloretz commented Jul 22, 2021

CI(build: --packages-above-and-dependencies python_cmake_module test: --packages-select python_cmake_module rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor Author

sloretz commented Jul 22, 2021

Windows CI build failure is unrelated: ros2/rclcpp#1726 , but since it was a build failure I'll run it again that nothing else fails to build because of this change.
Build Status

@sloretz sloretz merged commit eadcbe7 into master Jul 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the document_variables_set branch July 23, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants