use int64_t for period. #1010
Merged
use int64_t for period. #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Sep 30, 2022
|
@sloretz can you take a look at this? as you suggested, i think this makes more sense to address the issue. |
clalancette
requested changes
Oct 3, 2022
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
CI:
|
clalancette
approved these changes
Oct 3, 2022
clalancette
pushed a commit
that referenced
this pull request
Oct 13, 2022
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #967
see #974 (review)
Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com