use uint64_t for timer period.

[fujitatomoya]

address #967

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com

[fujitatomoya]

@sloretz can you take a look if you have time?

[fujitatomoya]

CI:

• Linux
• Linux-aarch64
• Windows

[Blast545]

Makes sense to me after checking #967

[Blast545]

@ros-pull-request-builder retest this please

[fujitatomoya]

@Blast545 thanks for checking on this, rpr job is unstable but CI all green. i need to merge ros2/rclpy#918 at the same time.

[sloretz]

I think rcl_timer_callback_t in rcl/timer.h needs to be updated too:

typedef void (* rcl_timer_callback_t)(rcl_timer_t *, int64_t);

[sloretz]

There are a few places where int64_t is being used to store the period still in timer.c

rcl/rcl/src/rcl/timer.c

Line 95 in d48fb11

const int64_t period = rcutils_atomic_load_uint64_t(&timer->impl->period);

There's some math with last_call_time and next_call_time which are int64_t types which may need special treatment to avoid compile warnings about mismatched signed/unsigned types. It might be easier to make period consistently int64_t than to make it uint64_t.

[fujitatomoya]

closing in favor of #974 (review), i believe this is the correct path.