Update rcl to C++17. #1031
Merged
Update rcl to C++17. #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two reasons to do this are:
1. So that we can compile rcl
with the clang static analyzer. As of clang++-14
(what is in Ubuntu 22.04), the default still seems
to be C++14, so we need to specify C++17 so that new
things in the rclcpp headers work properly.
2. So we can build with a newer version of gtest which requires this.
Further, due to reasons I don't fully understand, I needed to
set CMAKE_CXX_STANDARD_REQUIRED in order for clang to really use
that version. So set this as well.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
requested review from
audrow,
ivanpauno and
wjwwood
as code owners
fujitatomoya
approved these changes
Jan 31, 2023
mjcarroll
approved these changes
Jan 31, 2023
audrow
approved these changes
Jan 31, 2023
|
CI:
|
This was referenced Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two reasons to do this are:
Further, due to reasons I don't fully understand, I needed to set CMAKE_CXX_STANDARD_REQUIRED in order for clang to really use that version. So set this as well.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org