Use RCPPUTILS_SCOPE_EXIT to cleanup unparsed_indices_c. #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unique_ptr way to do this works, but clang static analysis complains that data could be leaked if the construction of the unique_ptr fails. Since this code is really old, switch to using RCPPUTILS_SCOPE_EXIT, which is our more modern way to deal with this problem. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
requested review from
sloretz and
adityapande-1995
as code owners
fujitatomoya
approved these changes
Feb 1, 2023
|
CI for this is in ros2/rcl#1031 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unique_ptr way to do this works, but clang static analysis complains that data could be leaked if the construction of the unique_ptr fails. Since this code is really old, switch to using RCPPUTILS_SCOPE_EXIT, which is our more modern way to deal with this problem.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org