localhost_only prevails auto discovery options if enabled. #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
May 13, 2023
There was a problem hiding this comment.
@clalancette @sloretz can you take a look when you have time?
This was referenced May 13, 2023
Merged
clalancette
requested changes
May 15, 2023
There was a problem hiding this comment.
Two small changes to the wording of the error messages, then I think this is good for me.
@fujitatomoya Thank you so much for doing this.
|
@clalancette thanks for the review, comments are addressed with 6fa485b |
|
CI:
|
clalancette
requested changes
May 16, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
force-pushed
the
fujitatomoya/fallback_discovery_options
branch
from
6fa485b
to
9951e88
Compare
clalancette
approved these changes
May 16, 2023
|
CI:
|
delete-merged-branch
bot
deleted the
fujitatomoya/fallback_discovery_options
branch
|
@Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 17, 2023
* localhost_only prevails auto discovery options if enabled. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 101e406)
|
@clalancette thanks for the review. |
clalancette
pushed a commit
that referenced
this pull request
May 17, 2023
danthony06
pushed a commit
to danthony06/rcl
that referenced
this pull request
Jun 14, 2023
* localhost_only prevails auto discovery options if enabled. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up of ros2/ros2#1359.
during deprecation period for
locaohost_onlyoption for Iron,locaohost_onlyprevails over discovery option which has been added with ros2/ros2#1359 as new feature.see ros2/ros2_documentation#3519 (comment) for more details and discussion.