Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some warnings from clang. #1042

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Fix some warnings from clang. #1042

merged 1 commit into from
Mar 6, 2023

Conversation

clalancette
Copy link
Contributor

  1. The "expected" variable should be default initialized, otherwise it might have a garbage value when being checked.
  2. Mark some variables in tests as unused.
  3. Call rcl_reset_error in a few more places.

@clalancette
Fix some warnings from clang.
9463523 
1. The "expected" variable should be default initialized,
otherwise it might have a garbage value when being checked.
2. Mark some variables in tests as unused.
3. Call rcl_reset_error in a few more places.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clalancette
Copy link
Contributor Author

The yellow tests on Windows are unrelated to this, so going ahead and merging.

@clalancette clalancette merged commit eb88a6d into rolling Mar 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the clalancette/clang-warnings branch March 6, 2023 17:46
danthony06 pushed a commit to danthony06/rcl that referenced this pull request Jun 14, 2023
@clalancette @danthony06
Fix some warnings from clang. (ros2#1042)
9336665 
1. The "expected" variable should be default initialized,
otherwise it might have a garbage value when being checked.
2. Mark some variables in tests as unused.
3. Call rcl_reset_error in a few more places.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

@wjwwood wjwwood Awaiting requested review from wjwwood wjwwood is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clalancette @mjcarroll @fujitatomoya